Fix #3441 let mark expressions be populated from the modern marker storage #3442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
RonnyPfannschmidt
commented
May 3, 2018
•
RonnyPfannschmidt
commented
- a test demonstrating it
nicoddemus
reviewed
May 3, 2018
testing/test_mark.py
Outdated
| deselected_tests = dlist[0].items | ||
| assert len(deselected_tests) == 1 | ||
|
|
||
| # keywords smear |
There was a problem hiding this comment.
Is this the intended behavior or just demonstrated an unwanted behavior that we plan to fix in the future?
There was a problem hiding this comment.
this is intended behaviour - i hope to kill keywords in a breaking release ^^ but thats a few years down the line as its not clear how to replace them
There was a problem hiding this comment.
OK thanks for the clarification. Would you mind add this explanation as a code comment?
|
(Btw I don't think adding "Fix #" in the PR title does anything, I think it needs to appear in the description body) |
RonnyPfannschmidt
force-pushed
the
fix-3441-markexpr-markstorage
branch
from
88f84f5
to
e6a86e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.