added indicative error when parametrizing an argument with a default … #3367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_pytest/compat.py
Outdated
| # Note: this code intentionally mirrors the code at the beginning of getfuncargnames, | ||
| # to get the arguments which were excluded from its result because they had default values | ||
| return tuple(p.name for p in signature(function).parameters.values() | ||
| if (p.kind is Parameter.POSITIONAL_OR_KEYWORD or |
There was a problem hiding this comment.
lets use a in check here instead of 2 is checks
nicoddemus
requested changes
Apr 5, 2018
There was a problem hiding this comment.
Looks good @brianmaissy, just a few minor comments.
Should we target master? This just improves the existing error message after all.
Also, can you post the full output of the error?
_pytest/python.py
Outdated
| @@ -797,13 +797,16 @@ def parametrize(self, argnames, argvalues, indirect=False, ids=None, | |||
| valtypes = {} | |||
| for arg in argnames: | |||
| if arg not in self.fixturenames: | |||
| if isinstance(indirect, (tuple, list)): | |||
| name = 'fixture' if arg in indirect else 'argument' | |||
| if arg in getdefaultargnames(self.function): | |||
There was a problem hiding this comment.
Please move getdefaultargnames out of the loop and store it into a set, no need to recompute it again during each iteration.
_pytest/compat.py
Outdated
| @@ -127,6 +127,15 @@ def getfuncargnames(function, is_method=False, cls=None): | |||
| return arg_names | |||
|
|
|||
|
|
|||
| def getdefaultargnames(function): | |||
There was a problem hiding this comment.
We are using pep8 names now, so please change this to get_default_arg_names
brianmaissy
force-pushed
the
feature/indicative_error_for_parametrize_with_default_argument
branch
from
6317aa0
to
d3fb77f
Compare
brianmaissy
force-pushed
the
feature/indicative_error_for_parametrize_with_default_argument
branch
from
d3fb77f
to
857098f
Compare
|
bump? |
RonnyPfannschmidt
approved these changes
Apr 23, 2018
nicoddemus
approved these changes
Apr 23, 2018
|
Thanks @brianmaissy for the PR and @RonnyPfannschmidt for the ping. 😁 |
brianmaissy
deleted the
feature/indicative_error_for_parametrize_with_default_argument
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3221