Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'-o' option no longer swallows all other non-options after it #3147

Merged
merged 7 commits into from
Jan 25, 2018

Conversation

nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Jan 23, 2018

The current behavior was too error-prone because a "-o" option would
swallow all the following non-option parameters:

pytest -o foo=bar path/to/test.py

path/to/test.py would be captured by the -o option, and would fail
because "path/to/test.py" is not in the format "key=value".

This supersedes #3133.

Fixes #3103

atoolan and others added 7 commits January 23, 2018 21:18
The current behavior was too error-prone because a "-o" option would
swallow all the following non-option parameters:

  pytest -o foo=bar path/to/test.py

path/to/test.py would be captured by the -o option, and would fail
because "path/to/test.py" is not in the format "key=value".
@nicoddemus
Copy link
Member Author

cc @arcoyle @atoolan

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0008%) to 92.626% when pulling 3f5e9ea on nicoddemus:issue-3103 into 3b3d237 on pytest-dev:features.

@nicoddemus nicoddemus changed the title -o option no longer swallow all other non-options after it '-o' option no longer swallow all other non-options after it Jan 24, 2018
@nicoddemus nicoddemus changed the title '-o' option no longer swallow all other non-options after it '-o' option no longer swallows all other non-options after it Jan 25, 2018
@nicoddemus nicoddemus merged commit 2aad8c0 into pytest-dev:features Jan 25, 2018
@nicoddemus nicoddemus deleted the issue-3103 branch January 25, 2018 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants