Always escape null bytes when setting PYTEST_CURRENT_TEST #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks for the quick turnaround! |
6 tasks
|
LGTM, thanks! |
| # python 2 doesn't like null bytes on environment variables (see #2644) | ||
| value = value.replace('\x00', '(null)') | ||
| # don't allow null bytes on environment variables (see #2644, #2957) | ||
| value = value.replace('\x00', '(null)') |
There was a problem hiding this comment.
i came to the conclusion thati this place is the completely wrong place to fix the issue
the real issue is that we allow bad test ids in the firs place - that is an full stop no go thing to begin with
There was a problem hiding this comment.
If we consider that null bytes make part of a "bad test ids" (which I think is reasonable) I agree this is not the bast place to put it.
It is of course simple enough to refactor this later without much fuss. Would mind opening an issue @RonnyPfannschmidt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2957
cc @mattsb42-aws