Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set xfail_strict=True in pytest's own test suite #2754

Merged
merged 2 commits into from
Sep 13, 2017
Merged

Set xfail_strict=True in pytest's own test suite #2754

merged 2 commits into from
Sep 13, 2017

Conversation

nicoddemus
Copy link
Member

Fix #2722

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.805% when pulling 10d43bd on nicoddemus:xfail_strict into 181bd60 on pytest-dev:master.

RonnyPfannschmidt
RonnyPfannschmidt approved these changes Sep 6, 2017
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 2.6 xpass makes me curious, i wonder how that was messed up

@nicoddemus
Copy link
Member Author

Removed that xfail then, I was actually surprised we only got one xpass. 👍

@RonnyPfannschmidt
Copy link
Member

the failure of coveralls is unrelated

@RonnyPfannschmidt RonnyPfannschmidt merged commit 70cdfaf into pytest-dev:master Sep 13, 2017
@nicoddemus nicoddemus deleted the xfail_strict branch September 13, 2017 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicoddemus @coveralls @RonnyPfannschmidt