Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "introduce deprecation warnings for legacy parametersets" #2584

Closed
wants to merge 1 commit into from
Closed

Revert "introduce deprecation warnings for legacy parametersets" #2584

wants to merge 1 commit into from

Conversation

nicoddemus
Copy link
Member

As discussed in #2573, this change introduced a serious regression.

Fix #2573

We should reopen #2427 after this is merged.

This reverts commit 0d0b01b.

@nicoddemus
Revert "introduce deprecation warnings for legacy parametersets"
6006e6a 
As discussed in pytest-dev#2573, this change introduced a serious regression.

Fix pytest-dev#2573

This reverts commit 0d0b01b.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 91.899% when pulling 6006e6a on nicoddemus:revert-2427 into 1485a3a on pytest-dev:features.

@The-Compiler
Copy link
Member

The warning from #2573 is "MarkInfo objects are deprecated as they contain the merged marks" and not this - see #2517. I'd only remove the warning and not revert the entire PR though.

The-Compiler
The-Compiler requested changes Jul 18, 2017
View reviewed changes
Copy link
Member

@The-Compiler The-Compiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong commit 😉

RonnyPfannschmidt
RonnyPfannschmidt reviewed Jul 18, 2017
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt left review comments

@The-Compiler The-Compiler The-Compiler requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicoddemus @coveralls @The-Compiler @RonnyPfannschmidt