Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Improve error message for CollectError with skip/skipif #2546

Merged
merged 1 commit into from
Jul 25, 2017
Merged

[RFC] Improve error message for CollectError with skip/skipif #2546

merged 1 commit into from
Jul 25, 2017

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jul 4, 2017 •
edited
Loading

TODO:

  • squash!

@nicoddemus
Copy link
Member

Thanks, looks good! Would you mind adding a "trivial" changelog file as well?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.138% when pulling 52d4920 on blueyed:better-skip-not-allowed-error into 6908d93 on pytest-dev:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.138% when pulling 52d4920 on blueyed:better-skip-not-allowed-error into 6908d93 on pytest-dev:master.

nicoddemus
nicoddemus requested changes Jul 5, 2017
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a "trivial" changelog file as well. It is nice to document small/trivial changes which might affect users.

Other than that LGTM.

@blueyed blueyed force-pushed the better-skip-not-allowed-error branch from 52d4920 to 72531f3 Compare July 25, 2017 13:14
@blueyed
Copy link
Contributor Author

blueyed commented Jul 25, 2017

Added the changelog entry and rebased it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.056% when pulling 72531f3 on blueyed:better-skip-not-allowed-error into 70d9f86 on pytest-dev:master.

nicoddemus
nicoddemus approved these changes Jul 25, 2017
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@nicoddemus nicoddemus merged commit 71947cb into pytest-dev:master Jul 25, 2017
@blueyed blueyed deleted the better-skip-not-allowed-error branch July 25, 2017 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-Compiler The-Compiler The-Compiler approved these changes

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blueyed @nicoddemus @coveralls @The-Compiler