Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail if imp can't find the source for a .pyc file. #2038 #2070

Merged
merged 1 commit into from
Nov 22, 2016
Merged

Conversation

nedbat
Copy link
Contributor

@nedbat nedbat commented Nov 20, 2016

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Target: for bug or doc fixes, target master; for new features, target features;

Unless your change is trivial documentation fix (e.g., a typo or reword of a small section) please:

  • Make sure to include one or more tests for your change;
  • Add yourself to AUTHORS;
  • Add a new entry to CHANGELOG.rst
    • Choose any open position to avoid merge conflicts with other PRs.
    • Add a link to the issue you are fixing (if any) using RST syntax.
    • The pytest team likes to have people to acknowledged in the CHANGELOG, so please add a thank note to yourself ("Thanks @user for the PR") and a link to your GitHub profile. It may sound weird thanking yourself, but otherwise a maintainer would have to do it manually before or after merging instead of just using GitHub's merge button. This makes it easier on the maintainers to merge PRs.

@nicoddemus
Copy link
Member

Fixes #2038 right?

Thanks a lot @nedbat for the PR. 👍

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.815% when pulling 06bb61b on nedbat:bug2038 into cbf261c on pytest-dev:master.

@nicoddemus
Copy link
Member

The linting env failed because of flake8-3.1.1, which is fixed by #2071.

@nicoddemus
Copy link
Member

Anybody still wants more time to take a look at this?

@RonnyPfannschmidt RonnyPfannschmidt merged commit a5b5090 into pytest-dev:master Nov 22, 2016
@RonnyPfannschmidt
Copy link
Member

its 👍

@nedbat nedbat deleted the bug2038 branch November 14, 2018 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants