Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved message when not using parametrized variable #1757

Conversation

jjanczyszyn
Copy link
Contributor

@jjanczyszyn jjanczyszyn commented Jul 23, 2016

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Target: for bug or doc fixes, target master; for new features, target features;
  • Make sure to include one or more tests for your change;
  • Add yourself to AUTHORS;
  • Add a new entry to CHANGELOG.rst
    • Choose any open position to avoid merge conflicts with other PRs.
    • Add a link to the issue you are fixing (if any) using RST syntax.
    • The pytest team likes to have people to acknowledged in the CHANGELOG, so please add a thank note to yourself ("Thanks @user for the PR") and a link to your GitHub profile. It may sound weird thanking yourself, but otherwise a maintainer would have to do it manually before or after merging instead of just using GitHub's merge button. This makes it easier on the maintainers to merge PRs.

@jjanczyszyn
Copy link
Contributor Author

@hackebrot

@hackebrot
Copy link
Member

Waiting for CI, but code LGTM 👍

@coveralls
Copy link

coveralls commented Jul 23, 2016

Coverage Status

Coverage increased (+0.002%) to 93.043% when pulling bbc7f3a on tramwaj29:improved-message-when-not-using-parametrized-variable into ae07985 on pytest-dev:features.

@@ -146,7 +146,8 @@ time or change existing behaviors in order to make them less surprising/more use
Thanks to `@anntzer`_ for the PR.


*
* Better message in case of not using parametrized variable (see `#1539`_).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the message looks good, I just think it should go under the Changes section instead of New Features.

@nicoddemus
Copy link
Member

Thanks! Aside from my minor comments, looks good! 👍

@hackebrot
Copy link
Member

Cool, happy to merge once @tramwaj29 addressed the comments.

@nicoddemus
Copy link
Member

(@hackebrot if you could do it great, I will have to go out to lunch in a few minutes 😁)

@hackebrot
Copy link
Member

No worries, I won't be until tomorrow, I think. There's no rush really 😄 We'll get it in before we release 3.0 for sure.

@jjanczyszyn
Copy link
Contributor Author

@hackebrot I'm not sure why the CI fails, tests on my local machine passed, I tried to merge changes from features branch into mine but there were none.

@hackebrot
Copy link
Member

@tramwaj29 there seems to be a conflict in CHANGELOG.rst. Did you update your local features branch with the upstream remote repository?

@jjanczyszyn
Copy link
Contributor Author

@hackebrot yeah sorry forgot about that 🐶

@coveralls
Copy link

coveralls commented Jul 24, 2016

Coverage Status

Coverage increased (+0.002%) to 93.062% when pulling 4aede6f on tramwaj29:improved-message-when-not-using-parametrized-variable into 9891593 on pytest-dev:features.

@nicoddemus nicoddemus merged commit a24146d into pytest-dev:features Jul 24, 2016
@hackebrot
Copy link
Member

Thank you @tramwaj29! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants