Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not discover properties when iterating fixtures #12781

Merged
merged 3 commits into from
Sep 8, 2024
Merged

do not discover properties when iterating fixtures #12781

merged 3 commits into from
Sep 8, 2024

Conversation

asottile
Copy link
Member

@asottile asottile commented Sep 5, 2024

resolves #12446

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Sep 5, 2024
nicoddemus
nicoddemus approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @asottile!

Left just some minor fixes/suggestions.

src/_pytest/fixtures.py Outdated Show resolved Hide resolved
src/_pytest/fixtures.py Outdated Show resolved Hide resolved
testing/python/collect.py Show resolved Hide resolved
testing/python/collect.py Show resolved Hide resolved
@nicoddemus nicoddemus added the backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch label Sep 5, 2024
@RonnyPfannschmidt
Copy link
Member

Nice one, I tried that in #6898 before but it went stale

@nicoddemus nicoddemus enabled auto-merge (squash) September 8, 2024 14:33
@nicoddemus nicoddemus merged commit c6a5290 into main Sep 8, 2024
29 checks passed
@nicoddemus nicoddemus deleted the do-not-collect-properties branch September 8, 2024 14:45
@patchback Patchback
Copy link

patchback bot commented Sep 8, 2024 •
edited
Loading

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/c6a529032231ccddd3040e8ab1a5a756eb9ea4a0/pr-12781

Backported as #12788

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 8, 2024
@asottile @patchback
Do not discover properties when iterating fixtures (#12781)
352ca16 
Resolves #12446

(cherry picked from commit c6a5290)
@patchback patchback bot mentioned this pull request Sep 8, 2024
Merged
@nicoddemus nicoddemus mentioned this pull request Sep 8, 2024
Draft
2 tasks
nicoddemus pushed a commit that referenced this pull request Sep 8, 2024
@patchback @asottile
Do not discover properties when iterating fixtures (#12781) (#12788)
a9910a4 
Resolves #12446

(cherry picked from commit c6a5290)

Co-authored-by: Anthony Sottile <asottile@umich.edu>
@astrofrog astrofrog mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch bot:chronographer:provided (automation) changelog entry is part of PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pytest 8.2.0 calls @propertys during unittest collection
3 participants
@asottile @RonnyPfannschmidt @nicoddemus