Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use False, instead of None as default for _XfailMarkDecorator's condition param and update doc #11600

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Nov 8, 2023

Thanks for submitting a PR, your contribution is really appreciated!

Here is a quick checklist that should be present in PRs.

  • Include documentation when adding new features.
  • [N/A] Include new tests or update existing tests when applicable.
  • Allow maintainers to push and squash when merging my commits. Please uncheck this if you prefer to squash the commits yourself.

If this change fixes an issue, please:

  • Add text like closes #XYZW to the PR description and/or commits (where XYZW is the issue number). See the github docs for more information.

Fixes comments pypa/setuptools#3979 (comment) and #10094 (comment)

This makes it explicit that None is not a contractually supported value (even if it "works" because it's falsy). See #11565 (comment)

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.

    Write sentences in the past or present tense, examples:

    • Improved verbose diff output with sequences.
    • Terminal summary statistics now use multiple colors.

    Also make sure to end the sentence with a ..

  • Add yourself to AUTHORS in alphabetical order.

@Avasam Avasam force-pushed the pytest.mark.xfail.condition branch from 195ffe9 to f573fb6 Compare November 8, 2023 20:02
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Avasam, LGTM! 👍

@RonnyPfannschmidt can you take a look too please?

@Avasam Avasam mentioned this pull request Nov 8, 2023
2 tasks
@bluetech bluetech merged commit 80442ae into pytest-dev:main Nov 17, 2023
24 checks passed
@Avasam Avasam deleted the pytest.mark.xfail.condition branch November 17, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants