-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config.getini default none value #11282 #11496
Closed
TanyaAgarwal28
wants to merge
14
commits into
pytest-dev:main
from
TanyaAgarwal28:config.getini_default_None_value
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
54b074b
Bug Fix 11456: Duplicated parameters in @pytest.mark.parametrize
TanyaAgarwal28 c526594
Merge branch 'pytest-dev:main' into main
TanyaAgarwal28 6c1eaf6
Bug Fix 11282: config.getini returns an empty list for an option of t…
TanyaAgarwal28 f61194f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9629387
Bug Fix 11282: config.getini returns an empty list for an option of t…
TanyaAgarwal28 6aa9319
Bug Fix 11282: config.getini returns an empty list for an option of t…
TanyaAgarwal28 888e9e8
Bug Fix 11282: config.getini returns an empty list for an option of t…
TanyaAgarwal28 b61719d
Bug Fix 11282: config.getini returns an empty list for an option of t…
TanyaAgarwal28 e07b993
Bug Fix 11282: config.getini returns an empty list for an option of t…
TanyaAgarwal28 af8162b
Bug Fix 11282: config.getini returns an empty list for an option of t…
TanyaAgarwal28 33eeda0
Bug Fix 11282: config.getini returns an empty list for an option of t…
TanyaAgarwal28 1d6a6d9
Bug Fix 11282: config.getini returns an empty list for an option of t…
TanyaAgarwal28 cfa662e
Bug Fix 11282: config.getini returns an empty list for an option of t…
TanyaAgarwal28 2bb9e30
Bug Fix 11282: config.getini returns an empty list for an option of t…
TanyaAgarwal28 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Return "None" as the default value if "None" or no default value if provided by the developer.In this approach, existing calls to the getini function would need to check for "None" values. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im very torn on this change in fear of the butterfly effec
at the same time and more propper solution will need a new api to avoid hell for users
@nicoddemus whats your impression on this
in particular the detail about the type is such, that for both None and string, it also makes sense to return a empty string