Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move py.code to pytest.code #103

Closed
pytestbot opened this issue Dec 20, 2011 · 7 comments
Closed

Move py.code to pytest.code #103

pytestbot opened this issue Dec 20, 2011 · 7 comments
Labels
type: enhancement new feature or API change, should be merged into features branch
Milestone
2.9

Comments

@pytestbot
Copy link
Contributor

Originally reported by: holger krekel (BitBucket: hpk42, GitHub: hpk42)

Often fixes to pytest actually need to happen in the pylib, namely py.code. Moreover, there probably are very few uses of the py.code.* API outside of pytest and pypy. Therefore i think it makes sense to remove the dependency of pytest on py.code and move the namespace to pytest.code.
@pytestbot pytestbot added the type: enhancement new feature or API change, should be merged into features branch label Jun 15, 2015
@RonnyPfannschmidt RonnyPfannschmidt added the good first issue easy issue that is friendly to new contributor label Jul 25, 2015
@RonnyPfannschmidt
Copy link
Member

this is mostly a code+test copy followed by adjustments, ask me on irc for details

@nicoddemus nicoddemus mentioned this issue Aug 27, 2015
Closed
@RonnyPfannschmidt RonnyPfannschmidt added this to the 3.0 milestone Sep 13, 2015
@Bjwebb
Copy link
Contributor

Bjwebb commented Sep 21, 2015

After poking around in py.code during the PyConUK sprint, I'm going to take a look at making this move.

@RonnyPfannschmidt
Copy link
Member

its rather tricky, i treif before but abadonded due to py.code having a lot of interaction via py.code usage internally - be carefull

@RonnyPfannschmidt RonnyPfannschmidt removed the good first issue easy issue that is friendly to new contributor label Sep 21, 2015
Bjwebb added a commit to Bjwebb/pytest that referenced this issue Sep 21, 2015
@Bjwebb
Move py.code to pytest.code pytest-dev#103
fe77fd4 
WIP, some tests still fail. Tests also need moving across.
@Bjwebb
Copy link
Contributor

Bjwebb commented Sep 21, 2015

I've made an attempt of this at master...Bjwebb:issue-103-move-py-code This now successfully runs the test suite on Python2.7 and 3.4, but there are still flakes errors - https://travis-ci.org/Bjwebb/pytest/builds/81460589

In order to get pytest.code I also moved pytest.py to pytest/__init__.py which is still causing problems for some of the other versions. Is there a better way to handle this?

@RonnyPfannschmidt
Copy link
Member

there should be no pytest.code for now,

its preferable that we have _pytest.code for now as a internal API thats allowed to change

@RonnyPfannschmidt RonnyPfannschmidt mentioned this issue Oct 10, 2015
Closed
@nicoddemus
Copy link
Member

@Bjwebb any news on this? Would you mind opening a PR targeting features, even if not ready to be merged yet?

This was referenced Nov 26, 2015
Closed
Closed
@nicoddemus nicoddemus modified the milestones: 2.9, 3.0 Nov 26, 2015
nicoddemus added a commit to nicoddemus/pytest that referenced this issue Nov 27, 2015
@nicoddemus
Moved py.code code over to py.test
a1b989d 
This is dependent on a feature branch of the py repository

Fix pytest-dev#103

test_assertion passed

Add code

Add code

All code tests passing

All tests passing

Add _pytest.code to list of packages

Fix flakes
nicoddemus added a commit to nicoddemus/pytest that referenced this issue Nov 27, 2015
@nicoddemus
Moved py.code code over to py.test
283dc43 
This is dependent on a feature branch of the py repository

Fix pytest-dev#103
@nicoddemus nicoddemus mentioned this issue Nov 27, 2015
Merged
nicoddemus added a commit to nicoddemus/pytest that referenced this issue Dec 22, 2015
@nicoddemus
Moved py.code code over to py.test
e3c665c 
Fix pytest-dev#103
@nicoddemus nicoddemus mentioned this issue Dec 24, 2015
Closed
@nicoddemus nicoddemus mentioned this issue Jan 15, 2016
Closed
nicoddemus added a commit to nicoddemus/pytest that referenced this issue Jan 26, 2016
@nicoddemus
Moved py.code code over to py.test
a912d37 
Fix pytest-dev#103
@RonnyPfannschmidt
Copy link
Member

fixed by the pr

@pytestbot pytestbot mentioned this issue May 30, 2018
Closed
fkohlgrueber pushed a commit to fkohlgrueber/pytest that referenced this issue Oct 27, 2018
@ambv
Add integration for pre-commit.com (pytest-dev#104)
f8e9544 
Fixes pytest-dev#103
@The-Compiler The-Compiler mentioned this issue Jan 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement new feature or API change, should be merged into features branch
Projects
None yet
Milestone
2.9
Development

No branches or pull requests
4 participants
@Bjwebb @RonnyPfannschmidt @nicoddemus @pytestbot