Support ansible_private_key_file as well
#448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentral1se
force-pushed
the
bugfix/support-other-ssh-private-key
branch
from
b97cec6
to
1c1b9f9
Compare
|
CI failure appears to be unrelated.
|
|
Looks reasonable to handle both, Merged, thanks! |
|
Thank you very much. I must now obligatorily beg you for a new release :) The next molecule release relies on this fix in Testinfra. |
|
Sure, It's in 3.0.5 ;) |
|
<3 |
decentral1se
added a commit
to decentral1se/molecule
that referenced
this pull request
May 30, 2019
ssbarnea
pushed a commit
to ansible/molecule
that referenced
this pull request
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, we received a report on ansible/molecule#2069 about Molecule failing to make an SSH connection and after a quick glance over in ansible/molecule#2069 (comment), I think I have a patch.
The short of it is, Ansible advertises that you can use both "ansible_ssh_private_key_file" and "ansible_private_key_file" for specifying SSH connection options and Molecule happens to use the "ansible_private_key_file" by default. The new Ansible runner implementation here in Testinfra (from what I can tell) does not pick this up.
Didn't dig too deeply on this but hopefully this goes in the right direction ...