Fixes CI issue with main + py11 #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The expected checks need changing before this can be merged - @bluetech would you mind doing this? I haven't merged anything here so I want to be sure you're okay with the change. |
|
Perhaps, integrate alls-green to avoid this in the future? |
|
Yes, the the required checks thing is a periodic bother. I'll try alls-green, thanks for the suggestion.
For the record, I'm okay with it :) |
|
I think it's more annoying when the matrix factors change, though. |
|
@bluetech merge me up scotty!! |
bluetech
force-pushed
the
kingbuzzman-patch-2
branch
from
3819b00 to
b87222b
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the title, django does not support py11 in the latest (main) branch and its causing that particular test to fail.
Let me know if you want me to move things around.
This came about because i wanted to do #1170 and ran into this issue there.