Move testing extras to a requirements_test.txt file #647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
testing
extras from the setup.py to their own requirements_test.txt file.Please let me know if I'm missing some details; I've put this together rather quickly.
The rationale here is that the
extras
list was showing up in a poetry.lock file for a project at my company. This was because pytest-cov was part of the dev-dependencies in a pyproject.toml file.Our vulnerability scanning tool is designed to skip development dependencies. However, it doesn't skip a development dependency if it appears in the extras list in the poetry.lock file. Edit: the previous line appears to be inaccurate - it is skipped if there are only dev dependencies in pyproject.toml.
This is not a problem with pytest-cov per-se but perhaps the change is acceptable in any case and helps others potentially. Maybe this PR makes sense from the perspective that the test extras would never be used by downstream users, but otherwise please feel free to close it😅
Thanks for your time!