Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support target_fixture in when and then steps. #431

Merged
merged 5 commits into from
Jul 3, 2021

Conversation

youtux
Copy link
Contributor

@youtux youtux commented Jul 3, 2021

As discussed in #402, we want to allow when and then steps to provide a target fixture.

Fixes #402, closes #405 and #419.

@codecov
Copy link

codecov bot commented Jul 3, 2021

Codecov Report

Merging #431 (f172bd6) into master (775b6dc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #431   +/-   ##
=======================================
  Coverage   96.13%   96.14%           
=======================================
  Files          50       50           
  Lines        1680     1684    +4     
  Branches      159      159           
=======================================
+ Hits         1615     1619    +4     
  Misses         38       38           
  Partials       27       27           
Impacted Files Coverage Δ
pytest_bdd/steps.py 97.95% <100.00%> (ø)
tests/feature/test_steps.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 775b6dc...f172bd6. Read the comment docs.

@youtux youtux requested a review from olegpidsadnyi July 3, 2021 08:26
Copy link
Contributor

@olegpidsadnyi olegpidsadnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@youtux youtux merged commit 98f6701 into master Jul 3, 2021
@youtux
Copy link
Contributor Author

youtux commented Jul 3, 2021

I'm going to make a 4.1.0 release then.

@youtux youtux deleted the then-when-target-fixture branch July 3, 2021 08:31
@youtux
Copy link
Contributor Author

youtux commented Jul 3, 2021

4.1.0 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Q: why '@when' doesn't export target_fixture?
2 participants