Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with pytest-xdist #56

Closed
wants to merge 2 commits into from
Closed

Test with pytest-xdist #56

wants to merge 2 commits into from

Conversation

orf
Copy link

@orf orf commented Jun 4, 2017

Re #55

tox.ini Outdated
@@ -6,6 +6,6 @@ deps =
pip >= 6
-rtest_requirements.txt
commands =
coverage run --source pytest_asyncio -m py.test
coverage run --source pytest_asyncio -m py.test -n 4
Copy link

@discosultan discosultan Jul 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use -n auto? It is described here and imo should be the default choice unless there's a reason to fix parallelism.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, this was a problem in Travis until pytest-dev/pytest-xdist#9, but should be good to go in the latest version. 👍

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know about the Travis issue. Glad there's a solution 🙂

@orf
Copy link
Author

orf commented Aug 1, 2018

I've updated the PR to run xdist on travis, plus made it run tests on MacOS.

@nicoddemus
Copy link
Member

@orf unfortunately pytest 3.7.0 is incompatible with pytest-asyncio: #89.

It should be fixed in pytest 3.7.1 though (pytest-dev/pytest#3754), so I suggest to pin to pytest!=3.7.0 for now.

@orf orf closed this Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants