Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py 1.5 breaks py.log: "No module named syslog" #170

Closed
nicoddemus opened this issue Nov 15, 2017 · 5 comments
Closed

py 1.5 breaks py.log: "No module named syslog" #170

nicoddemus opened this issue Nov 15, 2017 · 5 comments
Labels

Comments

@nicoddemus
Copy link
Member

Unfortunately the changes introduced in 7f46178 break on Windows, and my PR in #157 did not take the proper approach of detecting and fixing the problem. 😓

@nicoddemus
Copy link
Member Author

Fixed by #171

@mrbean-bremen
Copy link
Member

@nicoddemus - thanks for the fast fix!
There is one problem left though for existing Python 3.3 builds - as 1.5.0 is the last version supporting Python 3.3, this version is now installed with the latest py.test under Python 3.3 - that breaks pytest under Windows. It would be nice to have another version of py with Python 3.3 enabled in setup.py, so it can be installed from pypi for this version (alternatively, py.test requirements could be adapted to only accept py < 1.5.0 for Python 3.3).
What do you think?

@nicoddemus
Copy link
Member Author

Hi @mrbean-bremen, thanks for writing.

To solve this we were considering removing py-1.5.0 from PyPI given that it has irrevocably wrong meta-data. I guess this is the solution, so I will do that shortly.

alternatively, py.test requirements could be adapted to only accept py < 1.5.0 for Python 3.3

Indeed that's what we did in pytest-3.2.4, but there are issues with pip dependency resolver (see
pytest-dev/pytest#2926); if not for that I think we would not have had all this problems.

@nicoddemus
Copy link
Member Author

And it has been removed. @mrbean-bremen this should fix your builds now.

Hopefully this is the end of that.

@mrbean-bremen
Copy link
Member

@nicoddemus - thanks a lot, works like a charm now!

mrbean-bremen added a commit to pytest-dev/pyfakefs that referenced this issue Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants