Add "doctest" support #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was stemming from our use of the HEAPTYPE flag for our builtins, and cpython inferring "is builtin" from that. Also, fix a couple other minor things that I ran into.
ie what you create either on the repl (where we were close) or with `exec compile(foo, bar, "single")` (where we were not so close). With these changes, doctest seems to mostly be working.
My guess is that there's a build dependency issue, where we try building files that include libunwind.h before we run the rules that generate it. Not sure why we weren't running into that before. But the normal c++ files in src/ correctly depend on libunwind, but the ones in src/runtime/inline don't seem to. For good measure, don't include libunwind.h in our header files, and just use forward-declaring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed
tuple.__module__andsys.displayhooksupport.A number of cpython's tests use doctest, so getting this to work meant some of those now pass and others get farther.
test_doctestis unfortunately not working, but since they use doctest to test itself... it's hard to tell whether it's the testing or tested part that's failing (or both). If anyone is interested feel free to take a look :)