start templatizing the runtime to be able to choose exception styles #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exceptions thrown by len itself can now be either style, though any exceptions thrown by any called functions (ex __len__) will still get thrown as C++ exceptions and converted if needed. Helps in a common case of "try calling len but don't worry if no len was defined".
For use of PyObject_GetItem django_template3 ends up calling this a fair amount via unicode_translate (ie it checks to see if certain entries are in the translation table).
Apparently they can do compile-time evaluations, which is cool.
kmod
added a commit
that referenced
this pull request
Jul 28, 2015
start templatizing the runtime to be able to choose exception styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the goal of making sure that most exceptions we throw are CAPI exceptions rather that C++ exceptions. This is just some easy things for now: getattr, getitem, and len(). The plan is then to add runtimeCall, callattr, and then finally add support from the interpreter and/or jit to call the capi-style versions (ideally with some sort of profiling guidance).
For django_template3, these changes cut the number of calls to __cxa_throw from 44k to 27k, and the number of C frames we unwind from 395k to 240k.
Not sure why there's a fairly consistent regression in pyxl_bench; I tried looking into it and it seems dwarfed by variability so I'm punting on that for now.