More misc compatibility fixes #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for things (our build tools) that look for "python" explicitly.
kmod
force-pushed
the
metaserver_merge
branch
from
7d43786 to
d65ca85
Compare
This is not quite right since type.__call__ isn't even a proper function in CPython. But our handling of it is complicated enough that I think it's worth trying this workaround for now.
(a == b) != (b == a)
We had a few places where we added BoxedBuiltinFunctionOrMethod, which don't have bind-on-get behavior, causing issues with __call__
kmod
force-pushed
the
metaserver_merge
branch
from
d65ca85 to
50128e6
Compare
and disable a sqlalchemy test that was overspecific
kmod
force-pushed
the
metaserver_merge
branch
from
f5bf5f7 to
b3c96f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.