transform BST to gapless bytecode inplace #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all instructions of the CFG are directly emitted a single memory region - all instructions are packed and follow each other directly - the CFGBlock just stores the offset into the bytecode where the first instruction of the block is located - invokes are only a bit in the opcode field which when set means that the pointers to the normal and exc CFGBlocks* directly follow the normal instruction
…BST_ClassDef nodes
|
memory improvements are: |
undingen
changed the title
|
this also improves max rss for: s = """
class C(object):
def f(self):
return 'lalala'
C().f()
"""
for i in xrange(50000):
exec sfrom 124MB to 38MB. |
kmod
approved these changes
Nov 8, 2016
| @@ -4054,6 +4055,8 @@ void CodeConstants::dealloc() const { | |||
| owned_refs.clear(); | |||
| for (auto&& e : funcs_and_classes) { | |||
| Py_DECREF(e.second); | |||
| assert(e.first->type() == BST_TYPE::FunctionDef || e.first->type() == BST_TYPE::ClassDef); | |||
| delete[] e.first; | |||
this simplifies the code and removes a lot of ugliness
|
I fixed the |
|
lgtm! |
This was referenced Nov 10, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a modified version of #1381 which creates the bytecode in-place and does not evolve duplicating some CFG structures.
CFGBlocks*directly follow the normal instruction