Fix instancemethod comparisons #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had implemented instancemethod.__eq__, but not any of the other comparisons, and most importantly, not __hash__.
It was previously incorrectly succeeding: we happened to throw a similar-enough exception that the test thought we were testing the right thing. Once we fixed that bug, it turned up that we didn't throw the exception that the test is expecting. I don't like removing tests but this isn't any worse than the current situation of not really testing this functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had implemented instancemethod.eq, but not any of the other comparisons,
and most importantly, not hash.