Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs about stats option #1369

Merged
merged 1 commit into from
Sep 19, 2016
Merged

Fix docs about stats option #1369

merged 1 commit into from
Sep 19, 2016

Conversation

sh92
Copy link
Contributor

@sh92 sh92 commented Sep 19, 2016

I think the option about stats is outdated. Thx.

@undingen
Copy link
Contributor

good catch 👍, thanks for the change!

Could you please remove the libunwind commit it's causing the travis-ci error 😒 .
Unfortunately our build system currently applies some patches to libunwind (libunwind_patches/*) and git commits them during the build which causes cause libunwind to change - which means we normally never want to actually commit this changes because the revision will only exist on you host locally which causes the travis-ci error.

I have seen that there is another '-s' in README.md: -s Print out the internal stats at exit. could you change change that one too.

And would you mind signing the the CLA please: https://opensource.dropbox.com/cla/
I don't think it's absolutely necessary for this change but would be nice to have for the future :-)
Sorry for all my requests 😛

@sh92
Copy link
Contributor Author

sh92 commented Sep 19, 2016

OK, I fix it. This is my first project. I want to learn a lot in this project. Thank you for review. But I don't know how to sign the CLA? I failed to open the website when I clicked.

@undingen undingen merged commit 70993f0 into pyston:master Sep 19, 2016
@undingen
Copy link
Contributor

thanks for your patch 👍
I notified colleagues of mine to take a look into why the CLA site is down but I merged this in because it is a very small change. But if you plan to submit future PRs (please do 😄 ) you will have to sign it please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants