Be able to run an unmodified virtualenv #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmod
force-pushed
the
unmodified_venv
branch
2 times, most recently
from
de9aa13 to
add3040
Compare
Well, really an unmodified pip+setuptools The last piece is py_compile. Just shim that back into our parser to get the parser to write out a pyc file. It seems like we don't even need this -- most callers of py_compile (or at least, virtualenv), don't seem to care if the compile step passed or failed. But while we're here, try to support it.
Do it by patching distutils, which setuptools I guess builds on
kmod
force-pushed
the
unmodified_venv
branch
from
8db2521 to
928d5de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, really an unmodified pip+setuptools
The last piece is py_compile. Just shim that back into our parser
to get the parser to write out a pyc file.
It seems like we don't even need this -- most callers of py_compile
(or at least, virtualenv), don't seem to care if the compile step
passed or failed. But while we're here, try to support it.