BST: a bytecode-like AST #1356
Merged
BST: a bytecode-like AST #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove some extraneous things from bst
And make BST_arguments a bit safer by removing misleading fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use our AST data structures for representing both the AST from the parsed file, and also the bytecode-like semantics we add during the CFG phase. This PR splits those apart, so now we have an AST just for the syntax, and a BST that is dedicated to the bytecode level.
The main changes (beyond all the other PRs that led up to this) was in the CFG phase. It has to be more explicit now about whether it is operating on pre-CFG or post-CFG data structures. I also had to do some more refactoring to get it all to work together.
This opens up a lot of optimizations, which I haven't started to implement yet. There are a lot of fields on the BST classes that aren't used, lots of AST classes that are no longer used, etc.