Turn off implicit-function check in release mode #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm still hoping that we can keep this on in some way, because it continues to find issues. So let's try keeping it on for debug builds. I'm not sure if this is weakening the check enough (there may be other cases like scipy), but it's sounding like we need to have this check turned off in our releases regardless, such as issue pyston#1344.
I think it'd be nicer to just abort() like we do here, but cffi is actually testing this behavior (that loading an invalid library causes an ImportError). This is being exposed now because before, the library would fail to compile due to -Werror=implicit-function-declaration and not even get to the loading step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still hoping that we can keep this on in some way, because it continues to find issues.
So let's try keeping it on for debug builds.
I'm not sure if this is weakening the check enough (there may be other cases like scipy),
but it's sounding like we need to have this check turned off in our releases regardless,
such as issue #1344.
@undingen what do you think?