Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm tier: reduce scratch size #1025

Merged
merged 1 commit into from
Jan 25, 2016
Merged

llvm tier: reduce scratch size #1025

merged 1 commit into from
Jan 25, 2016

Conversation

undingen
Copy link
Contributor

@undingen undingen commented Dec 7, 2015

With the new frame introspection we don't need to save additional space for spilling vars which live in regs (except for deopts).
And for deopts we will never need more scratch than the one required for spilling the args.

                                   upstream/master:     origin/pp_stack:
           django_template3.py             2.1s (2)             2.1s (2)  -0.4%
                 pyxl_bench.py             1.8s (2)             1.8s (2)  +0.2%
     sqlalchemy_imperative2.py             2.2s (2)             2.2s (2)  -0.4%
                pyxl_bench2.py             1.1s (2)             1.1s (2)  -1.1%
       django_template3_10x.py            14.0s (2)            13.9s (2)  -0.6%
             pyxl_bench_10x.py            13.7s (2)            13.6s (2)  -1.0%
 sqlalchemy_imperative2_10x.py            16.9s (2)            17.0s (2)  +0.3%
            pyxl_bench2_10x.py             9.3s (2)             9.2s (2)  -0.8%
                       geomean                 4.8s                 4.8s  -0.5%

@undingen undingen force-pushed the pp_stack branch 2 times, most recently from 5bc53b6 to dfe3a81 Compare December 8, 2015 10:41
@kmod kmod assigned kmod and undingen and unassigned kmod Jan 25, 2016
@kmod
Copy link
Collaborator

kmod commented Jan 25, 2016

Seems reasonable; not sure if anything related to this has changed so that we would want to re-test it.

@kmod kmod added the accepted label Jan 25, 2016
With the new frame introspection we don't need to save additional space for spilling vars which live in regs (except for deopts).
And for deopts we will never need more scratch than the one required for spilling the args.
undingen added a commit that referenced this pull request Jan 25, 2016
llvm tier: reduce scratch size
@undingen undingen merged commit 189c7ac into pyston:master Jan 25, 2016
@undingen
Copy link
Contributor Author

I checked again perf numbers are:

                                   upstream/master:     origin/pp_stack:
           django_template3.py             2.1s (4)             2.1s (4)  -0.1%
                 pyxl_bench.py             1.8s (4)             1.8s (4)  +0.9%
     sqlalchemy_imperative2.py             2.2s (4)             2.2s (4)  -0.4%
                pyxl_bench2.py             1.1s (4)             1.0s (4)  -1.2%
       django_template3_10x.py            13.8s (4)            13.8s (4)  +0.2%
             pyxl_bench_10x.py            13.3s (4)            13.2s (4)  -1.2%
 sqlalchemy_imperative2_10x.py            17.0s (4)            17.0s (4)  -0.2%
            pyxl_bench2_10x.py             9.1s (4)             8.8s (4)  -2.4%
                       geomean                 4.7s                 4.7s  -0.5%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants