Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unicode entries in sys.path #599

Closed
kmod opened this issue Jun 9, 2015 · 0 comments
Closed

Allow unicode entries in sys.path #599

kmod opened this issue Jun 9, 2015 · 0 comments
Labels
probably easy

Comments

@kmod
Copy link
Collaborator

kmod commented Jun 9, 2015

Currently we ignore anything in sys.path that is not a str. We should handle unicode entries by converting to strings (CPython does it using PyUnicode_Encode(PyUnicode_AS_UNICODE(v), PyUnicode_GET_SIZE(v), Py_FileSystemDefaultEncoding, NULL);), and also allow subclasses of string.
@kmod kmod mentioned this issue Jul 29, 2015
Closed
KoykL added a commit to KoykL/pyston that referenced this issue Dec 24, 2015
@KoykL
Add tests for issue pyston#599
65388a2 
Add four separate tests with prefix of sys_path for four types of
sys.path entries: str, unicode, subclass of str, and subclass of
unicode.
undingen added a commit that referenced this issue Jan 4, 2016
@undingen
Merge pull request #1037 from LoyukiL/sys_path_unicode
7e58677 
Fix #599 by allowing subclasses of string and unicode in sys.path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
probably easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmod