-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: deprecate legacy API in favour of Graph-based functional implementation #619
Conversation
@@ -18,67 +18,30 @@ def setup_method(self): | |||
self.df_buildings["height"] = np.linspace(10.0, 30.0, 144) | |||
|
|||
def test_Area(self): | |||
with pytest.warns( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given we test the decorators and can silence these warnings, I am removing explicit checks from individual classes.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
=======================================
+ Coverage 97.4% 98.0% +0.6%
=======================================
Files 26 38 +12
Lines 4328 6158 +1830
=======================================
+ Hits 4214 6033 +1819
- Misses 114 125 +11
|
NeighboringStreetOrientationDeviation is missing. |
Can you look into that one? |
Closes #612
Adds decorators and custom warnings when decorator does not fit to remaining classes.
The only missing is
NeighboringStreetOrientationDeviation
. @u3ks what are we doing about that one?@u3ks also, can you review this if I'm pointing to correct things?