Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: allow silencing of FutureWarnings from legacy API #617

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

martinfleis
Copy link
Member

This introduces an environment variable ALLOW_LEGACY_MOMEPY which, when set to True, silences all the deprecation warnings about the legacy API.

I am open to a discussion about the name of the variable but I'd say anything without a possibility of conflicts is good enough.

@martinfleis martinfleis added this to the 0.8.0 milestone Jun 18, 2024
@martinfleis martinfleis requested review from u3ks and jGaboardi June 18, 2024 20:17
@martinfleis martinfleis self-assigned this Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.0%. Comparing base (4037c70) to head (cebb597).
Report is 85 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #617     +/-   ##
=======================================
+ Coverage   97.4%   98.0%   +0.6%     
=======================================
  Files         26      38     +12     
  Lines       4328    6115   +1787     
=======================================
+ Hits        4214    5993   +1779     
- Misses       114     122      +8     
Files with missing lines Coverage Δ
momepy/tests/test_utils.py 99.4% <100.0%> (+0.1%) ⬆️
momepy/utils.py 98.9% <100.0%> (+0.1%) ⬆️

Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ALLOW_LEGACY_MOMEPY is good enough. Maybe to be more concise we could do USE_LEGACY_MOMEPY, but the difference is trivial.

@martinfleis martinfleis merged commit 4681ba0 into pysal:main Jun 18, 2024
15 checks passed
@martinfleis martinfleis deleted the deprecation-env-var branch June 18, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants