-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: functional implementation of shape module #550
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
=======================================
+ Coverage 97.4% 97.5% +0.2%
=======================================
Files 26 28 +2
Lines 4328 4633 +305
=======================================
+ Hits 4214 4519 +305
Misses 114 114
|
Amazing. Very cool work.
No need to split. I will hunker down and get it down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small comments. Otherwise, v nice.
Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
Completely refactored
shape.py
. This was probably the easiest of them all.Performance comparison on data covering whole Prague:
Total speedup, to run all on a single city is 0.54, so we are now nearly twice as fast to compute the same.
@jGaboardi I am aware it is a loooong PR so can split it if you prefer that, but there's a ton of repetition in docstrings and tests so it is not that much.
I am also quite happy how the code looks compared to the original
shape.py
.