TYP: add type hints to functional._dimension #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinfleis
commented
Jan 12, 2024
| @@ -11,7 +14,10 @@ | |||
| ] | |||
|
|
|||
|
|
|||
| def volume(area, height): | |||
| def volume( | |||
| area: NDArray[np.float_] | Series, | |||
There was a problem hiding this comment.
Maybe we can do with a bare NDArray? Since I don't know how to add the same to Series anyway.
There was a problem hiding this comment.
Did you try: Series[np.float_]
There was a problem hiding this comment.
jGaboardi
approved these changes
Jan 12, 2024
| @@ -11,7 +14,10 @@ | |||
| ] | |||
|
|
|||
|
|
|||
| def volume(area, height): | |||
| def volume( | |||
| area: NDArray[np.float_] | Series, | |||
There was a problem hiding this comment.
Did you try: Series[np.float_]
|
Let's merge then. Can always adjust later if we figure it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppose this is how typing in momepy can look? Is that an improvement? Shall we do it?