-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add FaceArtifacts #510
Conversation
Codecov Report
@@ Coverage Diff @@
## main #510 +/- ##
=======================================
+ Coverage 97.2% 97.5% +0.3%
=======================================
Files 24 24
Lines 4110 4176 +66
=======================================
+ Hits 3996 4072 +76
+ Misses 114 104 -10
|
@anastassiavybornova can I ask for your review as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems sound, as far as I can tell. I will leave it up to @anastassiavybornova to review and approve.
Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Adding
FaceArtifacts
exposing the workflow from the upcoming paper by myself and @anastassiavybornova.I still need to figure out how to test this since the method works for large metro areas but not for smaller samples. It needs the critical mass of elements. I will play with it if I find some useful samples.