Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves bug in Percentiles append. #427

Merged
merged 4 commits into from
Sep 30, 2022
Merged

resolves bug in Percentiles append. #427

merged 4 commits into from
Sep 30, 2022

Conversation

jGaboardi
Copy link
Member

Resolves #426.

@jGaboardi jGaboardi self-assigned this Sep 21, 2022
@jGaboardi jGaboardi added the bug Something isn't working label Sep 21, 2022
@martinfleis
Copy link
Member

We should probably test this somehow.

@jGaboardi
Copy link
Member Author

We should probably test this somehow.

I've added two tests (one unweighted and one weighted) to check for correct behavior.

@jGaboardi
Copy link
Member Author

jGaboardi commented Sep 22, 2022 •
edited
Loading

xref #423

The py38 test is passing because test_get_network_ratio() is being skipped due to an older version of geopandas being installed.

Seems related to the regression that @jorisvandenbossche isolated pandas.

@jGaboardi
Copy link
Member Author

xref pandas-dev/pandas#48711

@jGaboardi
Copy link
Member Author

@martinfleis Anything more you think should be done for this?

martinfleis
martinfleis approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to see the green ci but given pandas release may not come soon, let's merge.

I am thinking we should do a patch release that changes our requirements to avoid ppl running into that bug...

@martinfleis martinfleis merged commit 7e5c8c5 into pysal:main Sep 30, 2022
@jGaboardi jGaboardi deleted the Percentiles_bug branch October 1, 2022 15:34
@jGaboardi jGaboardi mentioned this pull request Oct 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

Assignees

@jGaboardi jGaboardi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug in Percentiles append
2 participants
@jGaboardi @martinfleis