Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various warnings #398

Merged
merged 5 commits into from
Sep 12, 2022
Merged

Fix various warnings #398

merged 5 commits into from
Sep 12, 2022

Conversation

jGaboardi
Copy link
Member

Closes #397.

@jGaboardi jGaboardi self-assigned this Sep 12, 2022
martinfleis
martinfleis reviewed Sep 12, 2022
View reviewed changes
tests/test_elements.py Outdated Show resolved Hide resolved
martinfleis
martinfleis approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #398 (135e1b7) into main (26a6a64) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #398   +/-   ##
=====================================
  Coverage   95.9%   95.9%           
=====================================
  Files         13      13           
  Lines       2969    2969           
=====================================
  Hits        2848    2848           
  Misses       121     121
Impacted Files Coverage Δ
momepy/diversity.py 98.1% <ø> (ø)
momepy/dimension.py 98.4% <100.0%> (ø)

@martinfleis martinfleis merged commit 820d80e into pysal:main Sep 12, 2022
@jGaboardi jGaboardi deleted the sp_stats_mode_warning branch September 12, 2022 20:28
martinfleis pushed a commit that referenced this pull request Sep 20, 2022
@jGaboardi @martinfleis
Fix various warnings (#398)
e6219b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

Assignees

@jGaboardi jGaboardi

Labels
rough edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix thrown warnings in dimension, elements, diversity
2 participants
@jGaboardi @martinfleis