Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: remove deprecated pandas append #382

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Conversation

martinfleis
Copy link
Member

Replacing pandas append by concat to avoid the FutureWarning.

Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after we fix the doc generation issue.

Maybe spoke too soon...

@martinfleis
Copy link
Member Author

None of the failures is related to this PR. I think we can merge it. The docs issue is caused by the update of sphinx-pydata-theme but I haven't looked into why is it happening and what should be done about it.

@jGaboardi
Copy link
Member

OK, I'll merge once 3.9 finishes.

@jGaboardi jGaboardi merged commit 0ae6d95 into pysal:main Sep 7, 2022
@martinfleis martinfleis deleted the pandas_dep branch September 7, 2022 12:45
martinfleis added a commit that referenced this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants