Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add dropna keyword to Unique #280

Merged
merged 1 commit into from
Jul 19, 2021
Merged

ENH: add dropna keyword to Unique #280

merged 1 commit into from
Jul 19, 2021

Conversation

martinfleis
Copy link
Member

Closes #279

@martinfleis martinfleis added this to the 0.5.0 milestone Jul 19, 2021
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #280 (dfb04b7) into main (9d0096a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #280   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files          12       12           
  Lines        2540     2540           
=======================================
  Hits         2431     2431           
  Misses        109      109           
Impacted Files Coverage Δ
momepy/diversity.py 97.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d0096a...dfb04b7. Read the comment docs.

@martinfleis
Copy link
Member Author

The failure of the docs is fixed in geopandas master. Merging.

@martinfleis martinfleis merged commit 5148050 into main Jul 19, 2021
@martinfleis martinfleis deleted the unique_nan branch July 19, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

momepy.Unique counts Nans while it shouldn't
1 participant