Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: support MultiPolygons #234

Merged
merged 3 commits into from
Dec 21, 2020
Merged

ENH: support MultiPolygons #234

merged 3 commits into from
Dec 21, 2020

Conversation

martinfleis
Copy link
Member

Do not error on MultiPolygons in Corners and CentroidCorners. Untested but that is fine for now.

@martinfleis martinfleis added this to the 0.4.0 milestone Dec 21, 2020
@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #234 (47958a7) into master (d296118) will decrease coverage by 0.87%.
The diff coverage is 62.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   96.92%   96.05%   -0.88%     
==========================================
  Files          12       12              
  Lines        2634     2660      +26     
==========================================
+ Hits         2553     2555       +2     
- Misses         81      105      +24     
Impacted Files Coverage Δ
momepy/intensity.py 98.52% <ø> (ø)
momepy/preprocessing.py 92.85% <ø> (ø)
momepy/shape.py 90.60% <62.66%> (-5.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d296118...47958a7. Read the comment docs.

@martinfleis martinfleis merged commit a1a5060 into master Dec 21, 2020
@martinfleis martinfleis deleted the multipoly_support branch December 21, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant