Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: refactor SharedWallsRatio #191

Merged
merged 5 commits into from
Jul 21, 2020
Merged

PERF: refactor SharedWallsRatio #191

merged 5 commits into from
Jul 21, 2020

Conversation

martinfleis
Copy link
Member

Using sindex.query_bulk and fully vectorized operations. Requires geopandas 0.8+ as compat layer would be essentially reimplementing the same algorithm.

Bechmark from 185.296ms to 37.5±1ms.

@martinfleis martinfleis added this to the 0.3.0 milestone Jul 21, 2020
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #191 into master will decrease coverage by 0.11%.
The diff coverage is 97.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
- Coverage   94.07%   93.96%   -0.12%     
==========================================
  Files          11       11              
  Lines        2651     2666      +15     
==========================================
+ Hits         2494     2505      +11     
- Misses        157      161       +4     
Impacted Files Coverage Δ
momepy/distribution.py 97.31% <90.47%> (-0.80%) ⬇️
momepy/elements.py 91.57% <98.11%> (-0.51%) ⬇️
momepy/utils.py 83.94% <100.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 541bc9f...23e298a. Read the comment docs.

@martinfleis martinfleis merged commit 074dba1 into master Jul 21, 2020
@martinfleis martinfleis deleted the query branch July 21, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant