adapting mgwr to newest libpysal #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 26, 2018
Closed
|
You should have it now? I added all devs to write access for this repo.
On Sun, Aug 26, 2018 at 2:48 PM James Gaboardi ***@***.***> wrote:
This last build (79
<https://travis-ci.org/pysal/mgwr/builds/420651210?utm_source=github_status&utm_medium=notification>)
passes, but due to a connectivity issue build 79.4
<https://travis-ci.org/pysal/mgwr/jobs/420651214> failed and I currently
do not have the permissions on travis-ci to restart a build for mgwr.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#27 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACJY882OrIrtMrkLSdEs3wJqSqZnEHIxks5uUqcSgaJpZM4WMmgW>
.
--
Levi John Wolf
Lecturer in Quantitative Human Geography | University of Bristol
Fellow | Center for Spatial Data Science, University of Chicago
Associate Member | Center for Multilevel Modeling, University of Bristol
Director | Q-Step Program, School of Geographical Sciences, University of
Bristol
ljwolf.org
|
|
@ljwolf I have access to add labels and such to the GitHub repo but still do not have the option on travis to restart a build. Maybe it takes some time to kick in? At any rate, it is not a 'right now' problem that needs attention. |
weikang9009
reviewed
Aug 27, 2018
| ], | ||
| license='3-Clause BSD', | ||
| license='2-Clause BSD', |
There was a problem hiding this comment.
This might be less of a concern, but is it better to follow the 3-Clause BSD license suggested in the submodule_template?
There was a problem hiding this comment.
Good point, that I didn't consider. Should I go ahead and make the change or wait for Taylor's input since he is the maintainer?
There was a problem hiding this comment.
Let's wait for Taylor's input!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Justification: adapting
mgwrto newest version oflibpysal