Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding summary output #18

Merged
merged 7 commits into from
Jul 3, 2018
Merged

Adding summary output #18

merged 7 commits into from
Jul 3, 2018

Conversation

Ziqi-Li
Copy link
Member

@Ziqi-Li Ziqi-Li commented Jun 21, 2018

Adding summary output for GWR and MGWR. Related to #17
Here is the notebook showing the outputs.

@Ziqi-Li Ziqi-Li mentioned this pull request Jun 21, 2018
@TaylorOshan
Copy link
Collaborator

Done in spglm/#7, should allow aicc to be calculated for GLMResults object.

@Ziqi-Li
Copy link
Member Author

Ziqi-Li commented Jun 22, 2018

Thanks, just pushed a new commit reflecting that.

@TaylorOshan
Copy link
Collaborator

Looks good. A few potential tweaks:

  1. Will the method work for Poisson/Binomial? They have slightly different model fit diagnostics
  2. For MGWR, Should we add the corrected alpha value and corrected critical t-val for each variable next to ENP_J? This could be good to report.

@Ziqi-Li
Copy link
Member Author

Ziqi-Li commented Jun 25, 2018

For 1, yes, it works for Poisson/Binomial, see here at the bottom, I attached a summary output for the tokyo data.
For 2. Added the 95% covariate-specific t and alpha for mgwr in the new commit, also see this in the mgwr output.

@Ziqi-Li
Copy link
Member Author

Ziqi-Li commented Jun 25, 2018

Also, here is the output from gwr4 for the tokyo one.

@TaylorOshan TaylorOshan merged commit 72b37ca into pysal:master Jul 3, 2018
@Ziqi-Li Ziqi-Li deleted the summary branch July 3, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants