Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: RecursiveError in HeadTailBreaks #46

Merged
merged 1 commit into from
Sep 10, 2019
Merged

BUG: RecursiveError in HeadTailBreaks #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mapclassify/classifiers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def head_tail_breaks(values, cuts):
values = np.array(values)
mean = np.mean(values)
cuts.append(mean)
if len(values) > 1:
if len(set(values)) > 1:
return head_tail_breaks(values[values >= mean], cuts)
return cuts

Expand Down
7 changes: 7 additions & 0 deletions mapclassify/tests/test_mapclassify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,13 @@ def test_HeadTail_Breaks(self):
self.assertEqual(len(htb.counts), 4)
np.testing.assert_array_almost_equal(htb.counts, np.array([975, 21, 2, 1]))

def test_HeadTail_Breaks_doublemax(self):
V = np.append(self.V, self.V.max())
htb = HeadTail_Breaks(V)
self.assertEqual(htb.k, 4)
self.assertEqual(len(htb.counts), 4)
np.testing.assert_array_almost_equal(htb.counts, np.array([980, 17, 1, 2]))


class TestMapClassifier(unittest.TestCase):
def test_Map_Classifier(self):
Expand Down