Use libpysal.fuzzy_contiguity() in greedy
#154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #154 +/- ##
=======================================
- Coverage 89.0% 88.5% -0.6%
=======================================
Files 7 7
Lines 1082 1065 -17
=======================================
- Hits 963 942 -21
- Misses 119 123 +4
|
|
@martinfleis got time for quick review? |
martinfleis
approved these changes
Nov 23, 2022
|
I've somehow already reviewed this a few days ago but never approved. Sorry! |
|
It's a thanksgiving miracle! |
|
Don't think so, we don't have that over here :D. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
quantileandNaturalBreaksdoctests"min_distance"doctest was needed. The differing results from_geos_sw()tolibpysal.weights.fuzzy_contiguity()was due to_geos_sw()using a buffer resolution of 5, whereas the default buffer resolution withingeopandasis 16, which is used infuzzy_contiguity(). When testing_geos_sw()locally while changing the resolution to 16, the original doctest failed (results equivalent tofuzzy_contiguity()were observed).