Merge pull request #46 from martinfleis/headtail

BUG: RecursiveError in HeadTailBreaks
pysal · Sep 10, 2019 · 1986913 · 1986913
2 parents cc50f50 + ce4d3a3
commit 1986913
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/mapclassify/classifiers.py b/mapclassify/classifiers.py
@@ -192,7 +192,7 @@ def head_tail_breaks(values, cuts):
     values = np.array(values)
     mean = np.mean(values)
     cuts.append(mean)
-    if len(values) > 1:
+    if len(set(values)) > 1:
         return head_tail_breaks(values[values >= mean], cuts)
     return cuts
 

diff --git a/mapclassify/tests/test_mapclassify.py b/mapclassify/tests/test_mapclassify.py
@@ -330,6 +330,13 @@ def test_HeadTail_Breaks(self):
         self.assertEqual(len(htb.counts), 4)
         np.testing.assert_array_almost_equal(htb.counts, np.array([975, 21, 2, 1]))
 
+    def test_HeadTail_Breaks_doublemax(self):
+        V = np.append(self.V, self.V.max())
+        htb = HeadTail_Breaks(V)
+        self.assertEqual(htb.k, 4)
+        self.assertEqual(len(htb.counts), 4)
+        np.testing.assert_array_almost_equal(htb.counts, np.array([980, 17, 1, 2]))
+
 
 class TestMapClassifier(unittest.TestCase):
     def test_Map_Classifier(self):