-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: FWI direct download from EFFIS and GeoJSON conversion #77
Conversation
…he function list_files
use environment variables for connection
improve readability and handle empty buckets
Hello @GHCamille , thanks for this huge PR ! categories = [
(58, 6),
(145, 1),
(192, 5),
(210, 2),
(231, 4),
] Do you have a link where it is stated how categories are related to their values ? As value(2) > value(4) but value(2) < value(6), it is quite odd to me ? |
- restructure task - add retrieved_date option
lint & remove `pip install -r requirements.txt` step.
add localstack guidelines
[QUESTION] Should we keep the current CICD? Seems deprecated (@jsakv) |
Yes @Acruve15 the CI/CD is deprecated, multiple directories and modules are also deprecated and some unit tests are calling external API endpoints that are deprecated. What we can do is to:
Let me know if works for you! |
This pull request introduces several enhancements to the existing codebase:
Ability to write a JSON file to a s3 locally (using localstack)
FWI downloading through
requests
packageGeoJSON formatting so that it can be used in Pyronear platform
These changes aims at providing a risk MVP for the platform. There are still some grey areas for me, please MP me after reviewing so that we can go over it !
Please review the changes and provide feedback or approvals as necessary. Thank you!