Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pervent overlapping external labels in pie chart #352

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

xychang
Copy link
Contributor

@xychang xychang commented Apr 29, 2024

Description

Currently when there are multiple small categories in pie chart, the external label would overlap with each other.
Screenshot 2024-04-28 162205

This change will prevent it from happening but moving down the label up on detecting overlap.
Screenshot 2024-04-28 162446

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • If this is a bug fix, did you add or update a test file to the examples directory that verifies the bug is fixed?
  • If this is a new feature, did you add files to the examples directory to demonstrate the feature?
  • If this is a new feature, did you add documentation to the docs directory for the feature?

@xychang xychang marked this pull request as ready for review April 29, 2024 00:02
@lazyguru
Copy link
Collaborator

Thanks for your contribution

@lazyguru lazyguru merged commit bdccf2b into pyrochlore:master Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants