Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include LICENSE.md in sdist tarball #598

Merged
merged 4 commits into from
Oct 28, 2022
Merged

Include LICENSE.md in sdist tarball #598

merged 4 commits into from
Oct 28, 2022

Conversation

xhochy
Copy link
Contributor

@xhochy xhochy commented Oct 25, 2022

This ensures that the license is shipped in the sdist tarball on PyPI.

@jakirkham
Copy link

Think we can add this to setup.cfg

Comment on lines +1 to +3
[metadata]
# This includes the license file(s) in the wheel.
license_files = LICENSE.md

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also work for sdists

pypa/setuptools#1536

@fritzo
Copy link
Member

fritzo commented Oct 28, 2022

Hi @xhochy thanks for the fix. Could you merge in master to get the fix from #599 that's causing the CI failure? (I'm not sure how to do that as a maintainer from the github web ui)

@xhochy
Copy link
Contributor Author

xhochy commented Oct 28, 2022

Hi @xhochy thanks for the fix. Could you merge in master to get the fix from #599 that's causing the CI failure? (I'm not sure how to do that as a maintainer from the github web ui)

Done.

@fritzo fritzo merged commit 1b9b68d into pyro-ppl:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants