Sync Views bugfix, Copy State improvements #927
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Ehsan,
Sorry, missed your message in the last PR. Here are the same changes as in #893, with no outdated commits + one more bugfix. I've seen you've already made some changes in these files. If so, please have a look at the last commit:
Here are the old changes, from previous PR:
So it looks like we messed up Sync View (also in Copy State) a bit. It stopped working at all in the new release.
I did the fixes (bf7a39e , cced091) and added a couple of improvements:
Thanks,
Alex